fix(ui): clean redux cache when namespace or flag is deleted #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
=======================================
Coverage 73.02% 73.02%
=======================================
Files 85 85
Lines 8370 8370
=======================================
Hits 6112 6112
Misses 1880 1880
Partials 378 378 ☔ View full report in Codecov by Sentry. |
markphelps
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Redux RTK the UI could show a stale cache in the browser when user deletes a flag or a namespace and immediately recreated it with the same key. For namespace old segments will be displayed and for flags - rollouts or rules depending on flag type.