-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: First Time Onboarding #2732
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
==========================================
- Coverage 73.03% 72.96% -0.08%
==========================================
Files 85 85
Lines 8374 8374
==========================================
- Hits 6116 6110 -6
- Misses 1880 1884 +4
- Partials 378 380 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great!
I have only one comment and suggestion.
I have doubts about naming of user
store. It could confuse a bit in a future. self
in session is actually user information and having user
in store with non user information... Sadly I don't have any suggestion about better naming right now.
Good idea. I renamed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect!
This is a follow up to #2730
It has the following behaviour
user: { completedOnboarding }
value set, so it will show the newOnboarding
page with a button to say 'Completed'/flags
which was the previous default pageOnboarding
page fromSupport
, but noComplete
button will showThis PR also adds a new Button variant
soft
and changes the Button component to usevariant
instead ofprimary
It also fixes an issue with memorization and redux