Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: First Time Onboarding #2732

Merged
merged 4 commits into from
Feb 4, 2024
Merged

feat: First Time Onboarding #2732

merged 4 commits into from
Feb 4, 2024

Conversation

markphelps
Copy link
Collaborator

This is a follow up to #2730

It has the following behaviour

  • First time user runs Flipt, there will be no local storage user: { completedOnboarding } value set, so it will show the new Onboarding page with a button to say 'Completed'
  • Once user clicks this button, it will set the above mentioned value in local storage and redirect user to /flags which was the previous default page
  • User can still access Onboarding page from Support, but no Complete button will show

This PR also adds a new Button variant soft and changes the Button component to use variant instead of primary

It also fixes an issue with memorization and redux

@markphelps markphelps requested a review from a team as a code owner February 2, 2024 22:04
@markphelps markphelps requested a review from erka February 2, 2024 22:04
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32b7d1c) 73.03% compared to head (277f21f) 72.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   73.03%   72.96%   -0.08%     
==========================================
  Files          85       85              
  Lines        8374     8374              
==========================================
- Hits         6116     6110       -6     
- Misses       1880     1884       +4     
- Partials      378      380       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

I have only one comment and suggestion.
I have doubts about naming of user store. It could confuse a bit in a future. self in session is actually user information and having user in store with non user information... Sadly I don't have any suggestion about better naming right now.

ui/src/App.tsx Outdated Show resolved Hide resolved
@markphelps
Copy link
Collaborator Author

markphelps commented Feb 3, 2024

It looks great!

I have only one comment and suggestion. I have doubts about naming of user store. It could confuse a bit in a future. self in session is actually user information and having user in store with non user information... Sadly I don't have any suggestion about better naming right now.

Good idea. I renamed it to eventStore as its an event the user performs in the UI. Happy to think of other names as well though. I chose event because there may be other events/actions that we want to keep track of in the UI only in the future

@markphelps markphelps requested a review from erka February 3, 2024 19:03
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Feb 3, 2024
@markphelps markphelps merged commit 2dbfe61 into main Feb 4, 2024
31 of 33 checks passed
@markphelps markphelps deleted the onboarding-dismiss branch February 4, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants