fix(ui): increase z index for Slideover and Modal #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In flipt-io#2725 there were changes to z-index of header and Slideover and Modal is behind the header. It's visible in creating new token/namespace or in any modal dialog
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2758 +/- ##
==========================================
+ Coverage 70.78% 72.22% +1.43%
==========================================
Files 91 91
Lines 8729 7014 -1715
==========================================
- Hits 6179 5066 -1113
+ Misses 2165 1564 -601
+ Partials 385 384 -1 ☔ View full report in Codecov by Sentry. |
|
|
markphelps
added a commit
that referenced
this pull request
Feb 12, 2024
* main: chore(analytics): clean up query and the frontend respecting the changes chore(deps): bump stackhawk/hawkscan-action from 2.1.2 to 2.1.3 (#2762) chore(deps): bump golang in /build (#2759) chore(deps-dev): bump @types/uuid from 9.0.7 to 9.0.8 in /ui (#2766) chore(deps-dev): bump @playwright/test from 1.41.1 to 1.41.2 in /ui (#2765) chore(deps): bump @heroicons/react from 2.0.18 to 2.1.1 in /ui (#2763) chore(deps-dev): bump @types/react from 18.2.48 to 18.2.55 in /ui (#2761) chore(deps-dev): bump prettier from 3.2.4 to 3.2.5 in /ui (#2760) fix(ui): increase z index for Slideover and Modal (#2758) chore(ui): set seconds to 0 for input values on request fix: csp headers for formbricks (#2757) chore: address comments on format chore: fix spelling feat(analytics): add live updates with play/pause button chore: changelog for 1.37 release (#2754)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2725 there were changes to z-index of header and Slideover and Modal is behind the header. It's visible in creating new token/namespace or in any modal dialog