Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): support remote blob storage for service configuration #2983

Merged
merged 2 commits into from
Apr 14, 2024

address PR feedback and improve test coverage

2ecbd02
Select commit
Loading
Failed to load commit list.
Merged

feat(config): support remote blob storage for service configuration #2983

address PR feedback and improve test coverage
2ecbd02
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 14, 2024 in 0s

72.32% (+1.54%) compared to f997fb9

View this Pull Request on Codecov

72.32% (+1.54%) compared to f997fb9

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 72.32%. Comparing base (f997fb9) to head (2ecbd02).
Report is 230 commits behind head on main.

Files Patch % Lines
internal/config/config.go 62.50% 6 Missing and 6 partials ⚠️
internal/storage/fs/object/mux.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
+ Coverage   70.78%   72.32%   +1.54%     
==========================================
  Files          91       95       +4     
  Lines        8729     7217    -1512     
==========================================
- Hits         6179     5220     -959     
+ Misses       2165     1602     -563     
- Partials      385      395      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.