-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve open telemetry tracing instrumentation #2984
Conversation
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
763d20a
to
eb114fe
Compare
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
+ Coverage 70.78% 72.43% +1.65%
==========================================
Files 91 95 +4
Lines 8729 7271 -1458
==========================================
- Hits 6179 5267 -912
+ Misses 2165 1607 -558
- Partials 385 397 +12 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pablo Aguilar <pablo.aguilar@outlook.com.br>
369303b
to
e9d06aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great to me!! Thank you very much @thepabloaguilar ! Great work
This PR introduces two new configuration options under
tracing
section:Both additions are non breaking change as I kept the default value the same!
More information in the tracer resource was added as well as new span attributes for evaluation methods!
Additionally I've changed the imports of
go.opentelemetry.io/otel/semconv
to use the latest version as every import were using a different and old version! This also shouldn't break anythingCloses #2978