Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db metrics #314

Merged
merged 6 commits into from
Jul 8, 2020
Merged

Db metrics #314

merged 6 commits into from
Jul 8, 2020

Conversation

markphelps
Copy link
Collaborator

  • Add prometheus metrics around db connections
  • Update fqdn for cache metrics

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #314 into master will decrease coverage by 1.90%.
The diff coverage is 67.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
- Coverage   83.18%   81.28%   -1.91%     
==========================================
  Files          15       16       +1     
  Lines         886      999     +113     
==========================================
+ Hits          737      812      +75     
- Misses        116      155      +39     
+ Partials       33       32       -1     
Impacted Files Coverage Δ
storage/db/migrator.go 25.53% <0.00%> (ø)
storage/db/metrics.go 59.61% <59.61%> (ø)
config/config.go 90.74% <100.00%> (ø)
storage/cache/evaluation.go 76.47% <100.00%> (ø)
storage/cache/flag.go 95.23% <100.00%> (ø)
storage/cache/rule.go 86.95% <100.00%> (ø)
storage/cache/segment.go 95.23% <100.00%> (ø)
storage/db/db.go 91.30% <100.00%> (+12.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ffba34...3633bec. Read the comment docs.

@markphelps markphelps merged commit 490e399 into master Jul 8, 2020
@markphelps markphelps deleted the db-metrics branch July 8, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants