feat: show default value in flag table #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'main' of https://github.com/flipt-io/flipt: feat: default variants (#3271)
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
|
I think theres still some cleanup we can do on the boolean flag details page:
specifically:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
=======================================
Coverage 64.18% 64.18%
=======================================
Files 168 168
Lines 13506 13506
=======================================
Hits 8669 8669
Misses 4174 4174
Partials 663 663
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
markphelps
added a commit
that referenced
this pull request
Jul 23, 2024
* 'main' of https://github.com/flipt-io/flipt: feat: show default value in flag table (#3300)
This was referenced Jul 23, 2024
erka
added a commit
to erka/flipt
that referenced
this pull request
Aug 21, 2024
With all changes to flags dashboard and showing the boolean flags as always enabled this commit makes the same for console. related flipt-io#3300 Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
erka
added a commit
to erka/flipt
that referenced
this pull request
Aug 21, 2024
With all changes to flags dashboard and showing the boolean flags as always enabled this commit makes the same for console. related flipt-io#3300 Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
With all changes to flags dashboard and showing the boolean flags as always enabled this commit makes the same for console. related #3300 Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #2981
Re: #3271
enabledtoevaluation, meaning if evaluation will return a value