Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import): import flags with complex metadata #3639

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

erka
Copy link
Contributor

@erka erka commented Nov 21, 2024

This pull request includes several changes to the internal/ext package to enhance the encoding and importing functionalities.

  • yaml.v3 is used as import encoder. It returns map[string]any instead of map[any]any in jaml.v2.
  • fix the issue with importing json backups generated by flipt export -o file.json

closes #3635
closes #3636

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (1f6255d) to head (7fa170c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/ext/importer.go 52.63% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3639   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files         170      170           
  Lines       17020    17019    -1     
=======================================
  Hits        10946    10946           
+ Misses       5395     5392    -3     
- Partials      679      681    +2     
Flag Coverage Δ
unittests 64.31% <55.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@erka erka force-pushed the rd/import-flag-with-complex-metadata branch from 54c778c to 7fa170c Compare November 21, 2024 17:56
Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka erka marked this pull request as ready for review November 21, 2024 18:15
@erka erka requested a review from a team as a code owner November 21, 2024 18:15
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank yoU!!

@erka erka merged commit 1737085 into main Nov 21, 2024
38 of 39 checks passed
@erka erka deleted the rd/import-flag-with-complex-metadata branch November 21, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JSON import issue [Bug]: import metadata issue
2 participants