Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix the user profile icon #3741

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix(ui): fix the user profile icon #3741

merged 1 commit into from
Dec 18, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Dec 18, 2024

Before
image

After:
image

some regression in #3738

@erka erka requested a review from a team as a code owner December 18, 2024 22:14
@markphelps
Copy link
Collaborator

@erka can you post screenshot on the PR when there are UI changes please?

Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
@erka
Copy link
Collaborator Author

erka commented Dec 18, 2024

you are super fast today

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.63%. Comparing base (3bc41de) to head (53aed29).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3741   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files         170      170           
  Lines       17233    17233           
=======================================
  Hits        11139    11139           
  Misses       5399     5399           
  Partials      695      695           
Flag Coverage Δ
unittests 64.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@erka erka merged commit 4666d1e into main Dec 18, 2024
39 checks passed
@erka erka deleted the rd/fix-user-icon branch December 18, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants