Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/v2): add initial implementations of v2 env endpoints #3850

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

GeorgeMac
Copy link
Contributor

Supports #3832

Primarily, this brings in the new Environment storage abstraction and a server implementation which interfaces with it:

type Environment interface {
Name() string
// Namespaces
GetNamespace(_ context.Context, key string) (*environments.NamespaceResponse, error)
ListNamespaces(context.Context) (*environments.ListNamespacesResponse, error)
CreateNamespace(_ context.Context, rev string, _ *environments.Namespace) (string, error)
UpdateNamespace(_ context.Context, rev string, _ *environments.Namespace) (string, error)
DeleteNamespace(_ context.Context, rev, key string) (string, error)
// Resources
View(_ context.Context, typ ResourceType, fn ViewFunc) error
Update(_ context.Context, rev string, typ ResourceType, fn UpdateFunc) (string, error)
}

The upcoming environment storage implementation will be driven by configuration and the updated git storage backend, which will also come in a subsequent PR.

Additionally, this PR updates the declarative FS snapshot layer to drop the now defunkt storage API implementations.
These were all dependent on the now deleted protobuf definitions.

@GeorgeMac GeorgeMac requested a review from a team as a code owner January 27, 2025 14:17
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 27, 2025
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@GeorgeMac GeorgeMac merged commit a024a15 into v2 Jan 27, 2025
5 of 27 checks passed
@GeorgeMac GeorgeMac deleted the gm/v2-envs-server branch January 27, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants