Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase testing of providers #409

Merged
merged 29 commits into from
Jul 29, 2024
Merged

Conversation

sockmaster27
Copy link
Contributor

Fixes #393

@magnus-madsen
Copy link
Member

Looks like this is shaping up nicely. I am not sure why all the Flix source files start with an empty line.
That seems like a potential for future confusion.

Once the tests work, I guess we are more prepared to refactor the plugin?

@sockmaster27
Copy link
Contributor Author

Looks like this is shaping up nicely. I am not sure why all the Flix source files start with an empty line.

It was just practical, to make sure doing anything on position (0,0) should be a no-op, as a sanity check.

@magnus-madsen
Copy link
Member

Looks like this is shaping up nicely. I am not sure why all the Flix source files start with an empty line.

It was just practical, to make sure doing anything on position (0,0) should be a no-op, as a sanity check.

I think it could cause issues when someone has to copy some updated source code. We could add a comment saying blank or something.

@magnus-madsen
Copy link
Member

Let me know when this is ready for review / merge.

@sockmaster27
Copy link
Contributor Author

SymbolProvider appears to contain some bug (Illegal argument: line must be non-negative: Error: Illegal argument: line must be non-negative).

@magnus-madsen
Copy link
Member

Can you open a bug report with the input on the Flix repo? And then we can skip that provider.

@sockmaster27
Copy link
Contributor Author

@magnus-madsen Test got rate limited, could you retrigger it?

@sockmaster27 sockmaster27 marked this pull request as ready for review June 26, 2024 13:34
@magnus-madsen magnus-madsen merged commit 9232c28 into flix:master Jul 29, 2024
6 checks passed
@magnus-madsen
Copy link
Member

Merged. Thanks!

@sockmaster27 sockmaster27 deleted the providers2 branch July 29, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure every provider has at least a few tests
2 participants