fix: highlight tests shouldn't expect case parameters to be included in case highlight #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e included in the highlight, now they just expect the symbol
|
If this is merged will the #9071 report no errors? |
This unfortunately does not make all the tests pass. When I originally brough up this issue, I believe the remaining failures were due to tests that were wrong, but it turned out some were caused by that. There are remaining failures that were just due to legtiimate highlighting issues, namely the thin cursor problem and the record highlighting being broken. The former has been fixed so now only one test should fail, this one due to record highlighting being broken. I'm working on the record stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the highlight tests regarding enum cases. Before, they expected the parameters to be included in the highlight. For instance, for
case Circel(Int32)previouslyCircle(Int32)would be highlighted, whereas now onlyCirclewill be.Related to flix/flix#9114