Drop dependency on deprecated gulp-util #54
Conversation
| @@ -14,7 +14,7 @@ describe('stream', function () { | |||
| it('piping into second plumber should keep piping', function (done) { | |||
| gulp.src(fixturesGlob) | |||
| .pipe(plumber()) | |||
| .pipe(gutil.noop()) | |||
| .pipe(through2.obj()) | |||
There was a problem hiding this comment.
This is funny because gutil.noop was never a stream, it was just a noop function.
There was a problem hiding this comment.
To be honest I also was surprised by this: replacing it by an empty function caused the tests to fail. Then I noticed that it's actually calling the function: this functions returns a pass-through object stream. new PassThrough({objectMode: true}) also worked but since through2 was available I used it to match the old behavior:
module.exports = function () {
return through.obj();
};If I encounter it in other libraries, I'll submit a PR to document this on gulp-util's README.
There was a problem hiding this comment.
Oops, I didn't realize gutil had it as a noop stream. I guess I need to update the readme and blog post.
There was a problem hiding this comment.
@demurgos done! thanks for pointing that out.
|
@floatdrop can we get this merged? |
Closes #53