Skip to content

Commit

Permalink
Fixed /get_param service for arrays (RobotWebTools#776)
Browse files Browse the repository at this point in the history
**Public API Changes**
None


**Description**
The missing comma resulted in a wrong mapping of array parameters. For example, requesting a string array only returned an empty value because the type was given as index 9 (entry 10) but the type_mapping only had 9 entries. 

The error should be obvious, so I have not included an extra test.
  • Loading branch information
p0rys authored and jihoonl committed Oct 6, 2022
1 parent 7e4f91b commit c71ccd3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rosapi/src/rosapi/params.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"integer_value",
"double_value",
"string_value",
"byte_array_value" "bool_array_value",
"byte_array_value",
"bool_array_value",
"integer_array_value",
"double_array_value",
"string_array_value",
Expand Down

0 comments on commit c71ccd3

Please sign in to comment.