fix(hooks): Avoid setState in unmounted components. (#384)

floating-ui · Mar 4, 2021 · 32778e8 · 32778e8
1 parent a5ce0a2
commit 32778e8
Showing 1 changed file with 15 additions and 7 deletions.
diff --git a/src/Manager.js b/src/Manager.js
@@ -13,16 +13,24 @@ export type ManagerProps = {
 export function Manager({ children }: ManagerProps) {
   const [referenceNode, setReferenceNode] = React.useState<?Element>(null);
 
-  React.useEffect(
-    () => () => {
-      setReferenceNode(null);
-    },
-    [setReferenceNode]
-  );
+  const hasUnmounted = React.useRef(false);
+  React.useEffect(() => {
+    return () => {
+      hasUnmounted.current = true;
+    };
+  }, []);
+
+  const handleSetReferenceNode = React.useCallback((node) => {
+    if (!hasUnmounted.current) {
+      setReferenceNode(node);
+    }
+  }, []);
 
   return (
     <ManagerReferenceNodeContext.Provider value={referenceNode}>
-      <ManagerReferenceNodeSetterContext.Provider value={setReferenceNode}>
+      <ManagerReferenceNodeSetterContext.Provider
+        value={handleSetReferenceNode}
+      >
         {children}
       </ManagerReferenceNodeSetterContext.Provider>
     </ManagerReferenceNodeContext.Provider>