upgrade eth-sig-util #1039
Merged
upgrade eth-sig-util #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholtzman
previously approved these changes
Sep 16, 2022
mholtzman
added
the
WIP
goosewobbler
added
maintenance
hardware signers
hot signers
and removed
WIP
mholtzman
reviewed
Nov 27, 2022
| @@ -1,5 +1,5 @@ | |||
| const crypto = require('crypto') | |||
| const ethSigUtil = require('eth-sig-util') | |||
| const { signTypedData } = require('@metamask/eth-sig-util') | |||
There was a problem hiding this comment.
the worker has access to sensitive data so we just need to make sure every time we change or add a dependency here. this looks OK to me but just tagging @floating for double review
There was a problem hiding this comment.
Yeah, ideally we would use ethers for this too if we can. As discussed last week I think we get this in and then update again to switch to ethers if possible.
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
added 2 commits
November 27, 2022 18:00
mholtzman
reviewed
Nov 28, 2022
mholtzman
approved these changes
Nov 28, 2022
goosewobbler
added a commit
that referenced
this pull request
Nov 29, 2022
Co-authored-by: goosewobbler <goosewobbler@pm.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eth-sig-utiland upgraded all usage to@metamask/eth-sig-utilTODO: