Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting #1113

Closed
wants to merge 7 commits into from
Closed

Formatting #1113

wants to merge 7 commits into from

Conversation

goosewobbler
Copy link
Contributor

@goosewobbler goosewobbler commented Oct 20, 2022

Using prettier, lint-staged and husky to remove formatting nits from all PRs going forward. This does not include linting, saving that for another PR.

Prettier options: https://prettier.io/docs/en/options.html

Changes

  • lint-staged runs on husky pre-commit, which runs the format script, which runs prettier on TS, JS, MD, YML, JSON files.
  • formatting can be run and checked manually with npm run format and npm run format:check
  • unit tests run on husky pre-push - so no more PRs with broken tests, and zero tolerance for flaky tests

Prettier settings

Using @framelabs/prettier-config

In-editor formatting

Prettier VSCode formatter - not required for development but I usually have this configured to format on save:
https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode

TODO:

  • publish @framelabs/prettier-config
  • update package-lock.json
  • make hook files executable
  • ensure hooks work
  • deflake tests as necessary: 2166fd6 (#913)

@goosewobbler goosewobbler added the WIP PRs that are still in progress and not ready for review or merging label Oct 20, 2022
@goosewobbler goosewobbler mentioned this pull request Oct 20, 2022
@goosewobbler goosewobbler added this to the post-omnichain release milestone Nov 16, 2022
floating and others added 3 commits November 21, 2022 12:54
* removing critical deps

* remove redundant deps, get rid of critical warnings

* remove formatEther import

* address matts comments
Co-authored-by: goosewobbler <goosewobbler@pm.me>
@goosewobbler goosewobbler changed the base branch from develop to deps November 26, 2022 18:25
@goosewobbler
Copy link
Contributor Author

Closing in favour of #1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked tooling WIP PRs that are still in progress and not ready for review or merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants