Currency rework #1180
Currency rework #1180
Conversation
…e into tx-currency-display-rework
| </div> | ||
| <div className='signerBalancePrice'> | ||
| <div className='signerBalanceOk'> | ||
| <span className='signerBalanceCurrentPrice'> | ||
| {svg.usd(10)}{balance.price} | ||
| <DisplayValue type='fiat' value={`1e${decimals}`} valueDataParams={{ decimals, currencyRate, isTestnet, displayFullValue: true }} currencySymbol='$' /> |
There was a problem hiding this comment.
what is value in this context? we used to show the price, what are we showing now?
There was a problem hiding this comment.
What price did we used to show? The value here is one unit of x (non-fiat currency), the other parameters being required to display that value in terms of fiat currency for a given currencyRate. We could probably wrap this for readability
There was a problem hiding this comment.
There you go, now it shows the price
There was a problem hiding this comment.
it's just confusing is all. I would assume value would be what was previously the price but instead its 1 to the power of decimals which is not intuitive
|
@goosewobbler just left a couple comments. while I think this is a good step in the right direction, the interface in its current state is a bit complex and hard to follow. let's get this merged in and we can iterate over time into something that we find is easy to work with |
|
@mholtzman Yeah, I definitely feel like this needs some iterating on. Already had a couple of cycles across myself and Jordan, could do with more. I'll reply to your comments and make some adjustments tomorrow. |
test/app/Componentstotest/resources/Componentsto reflect the path of the tested files, updated test scripts accordingly