Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting #1337
Linting #1337
Changes from 11 commits
ff78b35
43e3176
7a96e6b
34b4080
f9ed60f
1e7024a
45d2580
47682bf
fa17aff
605ab12
ef3e1ed
a47488c
397c2f7
694eb71
41b51cc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want
process
to be available globally in all browser type files? seems like this might be a good case for one-of exceptions in individual files if we have anyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's available everywhere in the renderer process though
https://www.electronjs.org/docs/latest/api/process#sandbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't a global, it's Electron's process object which gets imported from the Electron library like
import { process } from 'electron
'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was sure that some renderer files have a global, anyway I'll try the exception route and put what I find here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, here are the renderer files where we're accessing a global process:
frame/app/dash/index.js
Line 15 in 9250bbf
frame/app/onboard/index.js
Line 15 in 9250bbf
frame/app/tray/index.js
Line 15 in 9250bbf
frame/app/dapp/index.js
Line 15 in 9250bbf
Entry points basically - I'll add an entry for these as the global isn't available any further up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we must be doing something to inject this value somewhere, though I'm not sure where. when I try to print
process.env
to the console it showsundefined
, butprocess.env.NODE_ENV
shows "development". are we somehow mapping this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think it's due to bullet point #4 here: https://en.parceljs.org/env.html#%F0%9F%8C%B3-environment-variables