Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use checksum for from address #1432

Merged
merged 2 commits into from
Feb 17, 2023
Merged

use checksum for from address #1432

merged 2 commits into from
Feb 17, 2023

Conversation

mholtzman
Copy link
Collaborator

No description provided.

@mholtzman mholtzman requested a review from Jamchello February 16, 2023 21:28
@@ -96,7 +94,8 @@ export function getRawTx(

const tx: TransactionData = {
...rawTx,
from: rawTx.from || accountId,
...(from && { from: getAddress(from) }),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this trick 🥇

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stackoverflow at its finest. I think its a little hard to tell whats going on but does the job for now

@mholtzman mholtzman merged commit 19e1598 into develop Feb 17, 2023
@mholtzman mholtzman deleted the raw-data-case branch February 17, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants