Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

step 1 missing during initial setup in "Connection to PSA" page #808

Closed
gernot-h opened this issue Mar 9, 2024 · 3 comments · Fixed by #809
Closed

step 1 missing during initial setup in "Connection to PSA" page #808

gernot-h opened this issue Mar 9, 2024 · 3 comments · Fixed by #809

Comments

@gernot-h
Copy link
Contributor

gernot-h commented Mar 9, 2024 •
edited
Loading

In 3.4.1, for my Opel account in DE, step 1 with the link to idpvcs.opel.com is not rendered during initial OAuth setup:

grafik

I guess html.A() in get_oauth_config_layout() is not rendered due to an unexpected value of redirect_url, debugging...
@gernot-h
Copy link
Contributor Author

gernot-h commented Mar 9, 2024

Hmm, according to https://docs.python.org/3/library/urllib.parse.html#module-urllib.parse, parse_qs in display_page() returns a list, so I wonder how this could work for others?

gernot-h added a commit to gernot-h/psa_car_controller that referenced this issue Mar 9, 2024
@gernot-h
fix: missing step 1 in config_connect()
4e48aeb 
The "Connection to PSA" page was not showing step 1 with the link to
Opel login page due to a type error. As parse_qs() returns a list, we
have to use first element.

Fixes flobz#808
@gernot-h gernot-h mentioned this issue Mar 9, 2024
Merged
@gernot-h
Copy link
Contributor Author

gernot-h commented Mar 9, 2024

Pushed #809 with the change fixing it for me.

@gernot-h
Copy link
Contributor Author

gernot-h commented Mar 9, 2024

Ah, there are a lot of people reporting this at #779, so I guess my fix should be needed and correct.

@flobz flobz closed this as completed in #809 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: missing step 1 in config_connect() gernot-h/psa_car_controller
1 participant
@gernot-h