Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vehicle chargings and trips API endpoint #795

Merged
merged 7 commits into from
Mar 23, 2024

Conversation

GewoonJaap
Copy link
Contributor

This PR adds endpoints to retrieve vehicles charging sessions and the trips.

@GewoonJaap
Copy link
Contributor Author

Also added CURL to the Docker image to support HTTP healthchecks for the container.

@flobz
Copy link
Owner

flobz commented Mar 19, 2024

thanks for you contribution I will look at it.

@GewoonJaap
Copy link
Contributor Author

Thank you @flobz I see the pipeline fails now because I added the curl package to enable docker HTTP health checks. Should I pin curl to a version?

@vineethktpla
Copy link

Very useful and good work @GewoonJaap . Was waiting for this for a long time and I hope it will merge soon.
This will ease my work in home assistant to track the trips. I am currently using trigger based automations to calculate and my trips and charging sessions

Copy link
Owner

@flobz flobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution.
Could you look to my suggested changes ?

psa_car_controller/web/view/api.py Outdated Show resolved Hide resolved
psa_car_controller/web/view/api.py Outdated Show resolved Hide resolved
psa_car_controller/web/view/api.py Outdated Show resolved Hide resolved
@GewoonJaap
Copy link
Contributor Author

Thanks for you contribution. Could you look to my suggested changes ?

Updated the API and readme with the new endpoints and changed the JSON return method as you suggested :)

@flobz
Copy link
Owner

flobz commented Mar 23, 2024

lgtm thanks !

@flobz flobz merged commit ba93ed1 into flobz:master Mar 23, 2024
1 check failed
@GewoonJaap GewoonJaap deleted the feature/more-data-as-api-endpoint branch March 23, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants