Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detected creation of folder loop, Moving 1 to 1 ? #1797

Open
1 task
sircode opened this issue Dec 14, 2024 · 11 comments
Open
1 task

Detected creation of folder loop, Moving 1 to 1 ? #1797

sircode opened this issue Dec 14, 2024 · 11 comments
Labels

Comments

@sircode
Copy link

sircode commented Dec 14, 2024

Which version of floccus are you using?

latest

How many bookmarks do you have, roughly?

testing 20

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

No response

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

Error:
Detected creation of folder loop, Moving 1 to 1 but it already contains a new parent node ?
I have no idea what it means.

Expected Behavior

Sync

To Reproduce

Don´t know, since I don´t understand the error

Debug log provided

  • I have provided a debug log file
@sircode sircode added the bug label Dec 14, 2024
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@sircode
Copy link
Author

sircode commented Dec 14, 2024

Screenshot_2024-12-11-14-28-59

@marcelklehr
Copy link
Member

Thank you for opening the issue 💙
Can you remember what you did before this error was displayed?

@marcelklehr
Copy link
Member

Also, can you go to settings and generate a debug log file? Can be redacted. Would be interesting to read.

@sircode
Copy link
Author

sircode commented Dec 14, 2024

Thank you for opening the issue 💙
Can you remember what you did before this error was displayed?

I think I added folders/subfolder in the app.

@marcelklehr
Copy link
Member

mmmh. Works fine for me.

@marcelklehr
Copy link
Member

I tried

  1. Create folder "Test" in root of android app with a WebDAV profile
  2. Create folder "Test" inside "Test" folder
  3. Create bookmark "Test" inside "Test"
  4. Sync with merge strategy
  5. Everything worked.

@marcelklehr
Copy link
Member

Which version of floccus are you using?
latest

Can you please check "About" for the actual version? 💙

@sircode
Copy link
Author

sircode commented Dec 15, 2024

v 5.3.1

if found out, that the error did occur with bookmarks.html
sync with bookmarks.xbel worked

After deleting bookmarks.html on the server, syncing bookmarks.html works.

After making some changes as .html , then switching to xbel again, syncing as bookmarks.xbel now returns an error : Failed to map parentid: 6

So the switching between xbel and html for testing, seems to cause the trouble.
So I guess that is not recommended.

@marcelklehr
Copy link
Member

marcelklehr commented Dec 15, 2024

v5.3.1

Can you try updating to v5.4.1 ? A lot of bugs have been fixed since v5.3.1

@marcelklehr
Copy link
Member

So the switching between xbel and html for testing, seems to cause the trouble.

I see. The cache needs to be reset when changing the file to sync with, I think. I'll implement that.

marcelklehr added a commit that referenced this issue Dec 15, 2024
see #1797

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@github-project-automation github-project-automation bot moved this to Backlog in Floccus Dec 15, 2024
@marcelklehr marcelklehr moved this from Backlog to Triaging in Floccus Dec 15, 2024
@marcelklehr marcelklehr moved this from Triaging to In progress in Floccus Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests

2 participants