Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

nick-add-basic-nodes #306

Merged
merged 17 commits into from
Sep 29, 2023
Merged

nick-add-basic-nodes #306

merged 17 commits into from
Sep 29, 2023

Conversation

youngsun4786
Copy link
Contributor

@youngsun4786 youngsun4786 commented Sep 23, 2023 •
edited
Loading

Description

  • I've included a concise description of what each node does

Styleguide

  • My node adheres to the styleguide for Flojoy nodes

Docs

  • I've submitted a PR for a documentation page for the new node(s) that contains usage examples (see docs.flojoy.io)

Testing

  • This PR includes a unit test (example here and/or ideally a screenshot of the node's output on an example app.

@youngsun4786 youngsun4786 changed the title nick/add basic nodes nick-add-basic-nodes Sep 23, 2023
@flojoy-bot flojoy-bot bot mentioned this pull request Sep 23, 2023
Merged
@dstrande dstrande self-requested a review September 25, 2023 14:23
dstrande
dstrande suggested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@dstrande dstrande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fix those comments as well as the test that's failing.

TRANSFORMERS/VECTOR_MANIPULATION/DECREMENT_ELEMENT/DECREMENT_ELEMENT.py Outdated Show resolved Hide resolved
TRANSFORMERS/VECTOR_MANIPULATION/ROTATE_VECTOR/ROTATE_VECTOR.py Outdated Show resolved Hide resolved
TRANSFORMERS/VECTOR_MANIPULATION/VECTOR_DELETE/VECTOR_DELETE.py Outdated Show resolved Hide resolved
TRANSFORMERS/VECTOR_MANIPULATION/VECTOR_SUBSET/VECTOR_SUBSET.py Show resolved Hide resolved
@dstrande dstrande merged commit 78d21b3 into develop Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dstrande dstrande dstrande approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngsun4786 @dstrande