Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron app release through CD #171

Merged
merged 12 commits into from
Mar 22, 2023
Merged

Electron app release through CD #171

merged 12 commits into from
Mar 22, 2023

Conversation

smahmed776
Copy link
Member

@smahmed776 smahmed776 commented Jan 21, 2023

Features added:

  • A loading screen for Electron app.
  • Detail error message in Electron app.
  • Fix path issues in both macOS and Linux platforms.
  • Modify docker files and add unnecessary folders to docker ignore.
  • Removed react-seven-segment-display package and commented out its corresponding component as this package doesn't meet the dependency requirement.

@smahmed776 smahmed776 linked an issue Jan 24, 2023 that may be closed by this pull request
@smahmed776 smahmed776 self-assigned this Jan 26, 2023
@smahmed776 smahmed776 marked this pull request as ready for review January 26, 2023 18:55
smahmed776 and others added 2 commits January 27, 2023 22:03

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@smahmed776 smahmed776 changed the title Build base image in CI and some changes in dockerfile Electron app release through CD Jan 28, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@smahmed776 smahmed776 requested a review from syridit February 3, 2023 21:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@SifatIbna SifatIbna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smahmed776 smahmed776 merged commit 810bbe5 into develop Mar 22, 2023
@smahmed776 smahmed776 deleted the electron-app branch March 22, 2023 02:36
flojoy-bot bot pushed a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One-click downloadable link to ElectronJS installer
3 participants