Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception for ImageMagick errors #48

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Add exception for ImageMagick errors #48

merged 2 commits into from
Mar 10, 2020

Conversation

olach
Copy link
Contributor

@olach olach commented Mar 10, 2020

The error reporting is missing in your copy of the ImageMagick class.

olach added 2 commits March 10, 2020 15:04
@olach
Add exception for ImageMagick errors
1e9e0c3
@olach
Same sort order for ImageMagick class as original
f6cf0a4 
Easier to compare the original ImageMagick class in the core Kirby installation.
@olach
Copy link
Contributor Author

olach commented Mar 10, 2020

Original ImageMagick class:

https://github.com/getkirby/kirby/blob/master/src/Image/Darkroom/ImageMagick.php#L87-L93

@flokosiol
Copy link
Owner

Thanks for the update, Ola!
Unfortunately I can't test it in the next time, but the changes look promising. So I take the risk and merge it directly. 😉

@flokosiol flokosiol merged commit 05fcd08 into flokosiol:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olach @flokosiol