Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

feat: improve robustness in case manager is down #289

Merged
merged 2 commits into from
Jun 26, 2023
Merged

feat: improve robustness in case manager is down #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a66d55
feat: improve robustness in case manager is down
reaver-flomesh Jun 26, 2023
9188a24
fix: FailurePolicy
reaver-flomesh Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/admission/admission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@ func NewMutatingWebhook(
caBundle []byte,
namespaceSelector *metav1.LabelSelector,
objectSelector *metav1.LabelSelector,
failurePolicy admissionregv1.FailurePolicyType,
rules []admissionregv1.RuleWithOperations,
) admissionregv1.MutatingWebhook {
failurePolicy := admissionregv1.Fail
//failurePolicy := admissionregv1.Fail
matchPolicy := admissionregv1.Exact
sideEffect := admissionregv1.SideEffectClassNone

Expand Down Expand Up @@ -129,9 +130,10 @@ func NewValidatingWebhook(
caBundle []byte,
namespaceSelector *metav1.LabelSelector,
objectSelector *metav1.LabelSelector,
failurePolicy admissionregv1.FailurePolicyType,
rules []admissionregv1.RuleWithOperations,
) admissionregv1.ValidatingWebhook {
failurePolicy := admissionregv1.Fail
//failurePolicy := admissionregv1.Fail
matchPolicy := admissionregv1.Exact
sideEffect := admissionregv1.SideEffectClassNone

Expand Down
1 change: 1 addition & 0 deletions pkg/injector/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
},
},
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/cluster/cluster_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -81,6 +82,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/cm/config_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nsSelector,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -84,6 +85,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nsSelector,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/flb/secret/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
commons.FlbSecretLabel: "true",
},
},
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -83,6 +84,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
commons.FlbSecretLabel: "true",
},
},
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/flb/service/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -76,6 +77,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/gateway/gateway_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -76,6 +77,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/gatewayclass/gatewayclass_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -76,6 +77,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/globaltrafficpolicy/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -75,6 +76,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/httproute/httproute_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -76,6 +77,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/ingress/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -77,6 +78,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Ignore,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/namespacedingress/namespacedingress_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -79,6 +80,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/proxyprofile/proxyprofile_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -77,6 +78,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/serviceexport/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -73,6 +74,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down
2 changes: 2 additions & 0 deletions pkg/webhooks/serviceimport/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand All @@ -74,6 +75,7 @@ func RegisterWebhooks(webhookSvcNs, webhookSvcName string, caBundle []byte) {
caBundle,
nil,
nil,
admissionregv1.Fail,
[]admissionregv1.RuleWithOperations{rule},
)

Expand Down