Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the preprocessor, Cygwin looks like OS_NIX which is mostly true. Cygwin is meant to look and feel like Unix but Cygwin applications run on Windows and require Windows-like naked assembly definitions. Otherwise, the application will segfault in ChunkMix.
Example:
Lumping Cygwin in with OS_WINDOWS would be incorrect, so instead I've added an extra check when defining
asm_naked_fn
to treat Cygwin as OS_WINDOWS for only that one block. This causes all tests to compile and run successfully.P.S. My editor stripped trailing whitespace which added a few extra lines to the commit. Sorry about that.