Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gettimeofday()-based get_ticks() #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

solardiz
Copy link

This actually implements the gettimeofday()-based get_ticks(), where the previous "implementation" looks like it was never even compile-tested. While it at, another commit here adds reporting of average tick counts (not only the minimum).

@solardiz
Copy link
Author

FWIW, I just used these (along with some hacks not suitable for a pull request) for quick-n-dirty benchmarks at 16384,8,1 computing classic scrypt vs. same with yescrypt's scrypt compat mode on 2xE5-2670 8xDDR3-1600, both AVX builds, both with memory (de)allocation out of loop, no huge pages. In this test, yescrypt's code is 4% faster at 1 process, 7% faster at 32 concurrent processes. Note: this is not native yescrypt, this is classic scrypt computed by the code in yescrypt. So it's apples to apples. I don't know why exactly the speed difference, but it could be in part because scrypt-jane doesn't do prefetches whereas yescrypt does (including in scrypt mode).

I needed the real time ticks for easier comparison to my benchmark of the yescrypt code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant