use addr instead unsafeAddr #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning:: `unsafeAddr` is a deprecated alias for `addr`, use `addr` instead.
|
Nice! Will try to take care of this and the PR in sokol-nim over the weekend. |
|
Ok, same NIm version compatibility problem in the CI pipeline like in floooh/sokol-nim#21 (comment). Can you try upgrade the nim-version here? sokol/.github/workflows/gen_bindings.yml Line 128 in 177e2c7 |
Angluca
force-pushed
the
master
branch
2 times, most recently
from
c6f4eca
to
8c70b26
Compare
|
...hmm, no idea what's going wrong there in the Nim setup... |
|
I test nim_version: devel is ok (devel is v1.9+, nim will upgrade to v2.0 at next year) |
|
Ok merged, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
warning::
unsafeAddris a deprecated alias foraddruse
addrinstead.