initial pass at fxhash support #12
Conversation
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
|
Added some more tests, and only base support |
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
|
It works!! You can check out your test mint on Floor here: (WIll deep link you on your phone) Very cool! I suspect I may have one additional ask later today (we're revving the interface slightly based on early learnings, but should be straightforward). You should be good to go!! 🙏 🥳 |
|
FYI — the updates I spoke of our new in an open PR for review by the Floor team 🙏 This hopefully improves your test & run story!! Thanks again for the feedback. |
|
Thanks for your patience @yungwkndllc. The PR is now merged into the main mobile minting repo. If you rebase against that, and get your ingestor working again, you're good to go! Thanks for begin first, and thanks for helping improve the framework 🙏 🙏 🙏 🙏 |
|
A reminder, you can now try your ingestor out on input with: |
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
When you ingest contracts for fxhash, are you picking up the minter (sales) contract or the token contract? For example which contract do you pick up for - https://www.fxhash.xyz/generative/slug/allegro
Need to know to implement the new |
Signed-off-by: yungwknd <yungwkndllc@gmail.com>
| { internalType: 'uint256', name: '_amount', type: 'uint256' }, | ||
| { internalType: 'address', name: '_to', type: 'address' }, | ||
| ], | ||
| name: 'buy', |
There was a problem hiding this comment.
For sanity of diff sizes, we favor trimmed ABIs — i.e. including only the objects describing the methods we care about.
In this case, everything except the buy and prices methods can be deleted.
There was a problem hiding this comment.
I've updated the README based on this too 🙏
ae8208e
This adds support for 2 cases of minting on FxHash -
I am sure there are other combinations of types of minting on their stuff out there, but wanted to get started with this at least.
Unit tests included - how do we run end to end testing?
Goes for this bounty - #5