Add setCreator method to builder. Add to FXHash #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismaddern
commented
Jun 30, 2024
| const totalPriceWei = await getFxHashMintPriceInEth( | ||
| contract.chainId, | ||
| contractAddress, | ||
| contract.contractAddress, | ||
| 1, | ||
| 0, |
There was a problem hiding this comment.
FYI @yungwkndllc I have no idea what this field is, but... it sometimes works with 1, but in all cases I could find it works with 0 when it works with 1, or when it won't work with 1.
So favoring 0 🤷
chrismaddern
requested review from
ckorhonen and
agans
and removed request for
ckorhonen and
agans
ckorhonen
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setCreatormethod to the builder to describe the creator (e.g. artist)setMintOutputContractto builder to identify the contract of the output NFT (if separate from the minting contract)Updates the FXhash ingestor to support these properties.