Rodeo ingestion

[Myestery]

Mint Ingestor: Rodeo Club

Functionality Supported

• Ingesting from URL: Yes
• Ingesting from Contract address: Yes
• Supported Networks: Base

Before you submit

• Ensure your generated MintTemplate works 😄
• Ensure that your code is restricted to a single folder in src/ingestors
• Ensure that all required assets are included (e.g. ABIs)
• Ensure ABIs are trimmed to include only methods (1) used in the ingestor or (2) required to mint
• Ensure that all exported methods are prefixed with the name of your ingestor e.g. myMintingPlatformGetContractDetails
• Ensure that a test exists for generating a MintTemplate that will always succeed
• Ensure that your code accesses no external resources except those passed in the resources object

fix #35

[chrismaddern]

Hey @Myestery 👋

Excited to see you hopping in on another one!!

Just a headsup that we've gotten a few questions from other folks wanting to jump in here too, so for incomplete submissions we'll only hold the bounty for the first submitter for a few days.

Just wanted to give you a heads up since you were first, but it's not built yet.

[Myestery]

oh yeah
I understand that and would turn this into a real PR tomorrow
I already worked on it during the weekend

[Myestery]

Hello @christinehall This PR should ready for merge now
I've handled every issue that there was

[Myestery]

[chrismaddern]

/review

[qodo-merge-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Key issues to review Hardcoded Address The mintAddress is hardcoded in the createMintForContract method. This could be a potential issue if the address changes or if different addresses are used for different environments. Error Handling The error handling in the getRodeoMintByAddressAndChain function could be improved. It currently catches all errors and throws a generic MintIngestorError. More specific error handling could provide better debugging information. Potential Overflow The getRodeoFeeInEth function adds several BigNumber values. There's a potential for overflow if these values are extremely large. Consider using BigNumber.add with appropriate error checking.

[chrismaddern]

Congratulations on a single-review accepted PR!!!

Great job! Would love to see more of these 🥳

[chrismaddern]

DMd you on twitter 😊