Change minted on floor.fun to minted on rally.xyz for zora mint comments

[agans]

User description

Mint Ingestor:

Functionality Supported

• Ingesting from URL: Yes / No
• Ingesting from Contract address: Yes / No
• Supported Networks: Base / Ethereum / Arbitrum / Zora / Polygon / Others..

Before you submit

• Ensure your generated MintTemplate works 😄
• Ensure that your code is restricted to a single folder in src/ingestors
• Ensure that all required assets are included (e.g. ABIs)
• Ensure ABIs are trimmed to include only methods (1) used in the ingestor or (2) required to mint
• Ensure that all exported methods are prefixed with the name of your ingestor e.g. myMintingPlatformGetContractDetails
• Ensure that a test exists for generating a MintTemplate that will always succeed
• Ensure that your code accesses no external resources except those passed in the resources object

---

PR Type

enhancement

---

Description

• Updated the mint comment in the ZoraMetadataProvider class for the ZORA_TIMED mint type from "Minted on floor.fun" to "Minted on rally.xyz".
• Added a new subproject commit reference in the scripts/floornfts file.

---

Changes walkthrough 📝

	Relevant files
Enhancement	zora-metadata.ts Update mint comment for ZORA_TIMED mint type                          src/ingestors/zora-internal/zora-metadata.ts Updated the comment in the params array for the ZORA_TIMED mint type. Changed the comment from "Minted on floor.fun" to "Minted on rally.xyz". +1/-1
Miscellaneous	floornfts Add subproject commit reference                                                    scripts/floornfts Added a new subproject commit reference. +1/-0

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

CI Failure Feedback 🧐

Action: build

Failed stage: Run actions/checkout@v3 [❌]

Failure summary: The action failed because of an error related to Git submodules: The error message "fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules" indicates that there is a missing URL configuration for a submodule in the .gitmodules file. This caused the Git command to fail with exit code 128, which is why the action did not complete successfully.

Relevant error logs: 1: ##[group]Operating System 2: Ubuntu ... 426: Switched to a new branch 'alicia/minted-on-rally' 427: branch 'alicia/minted-on-rally' set up to track 'origin/alicia/minted-on-rally'. 428: ##[endgroup] 429: [command]/usr/bin/git log -1 --format='%H' 430: 'ff5c6c3e112c2a297254f9c38db960506ea8d22f' 431: ##[group]Removing auth 432: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 433: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 434: ##[error]fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules 435: ##[error]The process '/usr/bin/git' failed with exit code 128 ... 437: [command]/usr/bin/git version 438: git version 2.46.1 439: Temporarily overriding HOME='/home/runner/work/_temp/2e9cbc69-e1d4-42fb-a278-799e1a5cfcaf' before making global git config changes 440: Adding repository directory to the temporary git global config as a safe directory 441: [command]/usr/bin/git config --global --add safe.directory /home/runner/work/mobile-minting/mobile-minting 442: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 443: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 444: fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules 445: ##[warning]The process '/usr/bin/git' failed with exit code 128

---

✨ CI feedback usage guide:

---

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

• Failed stage
• Failed test name
• Failure summary
• Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

• enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
• excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
• enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
• persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
• final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Branding Update The mint comment has been changed from "Minted on floor.fun" to "Minted on rally.xyz". Ensure this change aligns with the intended branding and user experience.

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Maintainability	Use a constant for the minting platform name to improve maintainability Consider using a constant or configuration variable for the "Minted on rally.xyz" string. This would make it easier to update the minting platform name in the future if needed, and ensure consistency across the codebase. src/ingestors/zora-internal/zora-metadata.ts [144] -params = `[address, quantity, "${tokenDetails.collection.address}", tokenId, "${FLOOR_REFERRER_REWARDS_ADDRESS}", "Minted on rally.xyz"]`; +const MINTING_PLATFORM = 'rally.xyz'; +params = `[address, quantity, "${tokenDetails.collection.address}", tokenId, "${FLOOR_REFERRER_REWARDS_ADDRESS}", "Minted on ${MINTING_PLATFORM}"]`; Apply this suggestion Suggestion importance[1-10]: 7 Why: This suggestion improves maintainability by using a constant for the minting platform name, making future updates easier and ensuring consistency across the codebase. It is a good practice to externalize such strings, especially if they might change.	7
Consistency	Update the referrer rewards address constant name to match the new platform The FLOOR_REFERRER_REWARDS_ADDRESS constant seems to be still in use, but the minting platform has changed from floor.fun to rally.xyz. Consider updating this constant name to reflect the new platform, or use a more generic name if it's still applicable. src/ingestors/zora-internal/zora-metadata.ts [144] -params = `[address, quantity, "${tokenDetails.collection.address}", tokenId, "${FLOOR_REFERRER_REWARDS_ADDRESS}", "Minted on rally.xyz"]`; +params = `[address, quantity, "${tokenDetails.collection.address}", tokenId, "${RALLY_REFERRER_REWARDS_ADDRESS}", "Minted on rally.xyz"]`; Apply this suggestion Suggestion importance[1-10]: 5 Why: While the suggestion to rename the constant for consistency is reasonable, it assumes that the referrer rewards address is platform-specific. Without more context, it's unclear if this change is necessary, but it could improve clarity if the address is indeed tied to the platform.	5

💡 Need additional feedback ? start a PR chat

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

CI Failure Feedback 🧐

Action: build

Failed stage: Run actions/checkout@v3 [❌]

Failure summary: The action failed due to an issue with Git submodules: The error "No url found for submodule path 'scripts/***nfts' in .gitmodules" indicates that the submodule configuration is incomplete or missing. The process '/usr/bin/git' failed with exit code 128 because it could not find the URL for the specified submodule path in the '.gitmodules' file.

Relevant error logs: 1: ##[group]Operating System 2: Ubuntu ... 426: Switched to a new branch 'alicia/minted-on-rally' 427: branch 'alicia/minted-on-rally' set up to track 'origin/alicia/minted-on-rally'. 428: ##[endgroup] 429: [command]/usr/bin/git log -1 --format='%H' 430: 'ff5c6c3e112c2a297254f9c38db960506ea8d22f' 431: ##[group]Removing auth 432: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 433: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 434: ##[error]fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules 435: ##[error]The process '/usr/bin/git' failed with exit code 128 ... 437: [command]/usr/bin/git version 438: git version 2.46.1 439: Temporarily overriding HOME='/home/runner/work/_temp/307ed05d-0a0e-49c5-aa5c-8e9ae2b286bc' before making global git config changes 440: Adding repository directory to the temporary git global config as a safe directory 441: [command]/usr/bin/git config --global --add safe.directory /home/runner/work/mobile-minting/mobile-minting 442: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 443: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 444: fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules 445: ##[warning]The process '/usr/bin/git' failed with exit code 128

---

✨ CI feedback usage guide:

---

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

• Failed stage
• Failed test name
• Failure summary
• Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

• enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
• excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
• enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
• persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
• final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

[agans]

@chrismaddern can you help me understand why the build might be failing on this? 🤔

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

CI Failure Feedback 🧐

Action: build

Failed stage: Run actions/checkout@v3 [❌]

Failure summary: The action failed because of an issue with Git submodules: The error fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules indicates that there is a missing URL configuration for the submodule in the .gitmodules file. This caused the Git command to fail with exit code 128.

Relevant error logs: 1: ##[group]Operating System 2: Ubuntu ... 424: Switched to a new branch 'alicia/minted-on-rally' 425: branch 'alicia/minted-on-rally' set up to track 'origin/alicia/minted-on-rally'. 426: ##[endgroup] 427: [command]/usr/bin/git log -1 --format='%H' 428: 'ff5c6c3e112c2a297254f9c38db960506ea8d22f' 429: ##[group]Removing auth 430: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 431: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 432: ##[error]fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules 433: ##[error]The process '/usr/bin/git' failed with exit code 128 ... 435: [command]/usr/bin/git version 436: git version 2.46.1 437: Temporarily overriding HOME='/home/runner/work/_temp/20d966ef-a63c-4d20-81a3-01d019e1acef' before making global git config changes 438: Adding repository directory to the temporary git global config as a safe directory 439: [command]/usr/bin/git config --global --add safe.directory /home/runner/work/mobile-minting/mobile-minting 440: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 441: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 442: fatal: No url found for submodule path 'scripts/***nfts' in .gitmodules 443: ##[warning]The process '/usr/bin/git' failed with exit code 128

---

✨ CI feedback usage guide:

---

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

• Failed stage
• Failed test name
• Failure summary
• Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

• enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
• excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
• enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
• persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
• final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

[chrismaddern]

@agans I'm not quite sure what happened but it looks like a submodule got added in your commit

In this case, it looks like the clone from using yarn run test-fork

I don't see anything in .gitignore that's preventing that so I'm curious why it hasn't happened before...

Recommend:

• Removing the subfolder from git (to remove the submodule)
• Deleting the folder
• Adding /scripts/clones to the .gitignore
• Push again

Sorry about that... I'm a little confused how we got here, but that should fix it for you, and for anyone else in the future

[qodo-merge-pro]

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

CI Failure Feedback 🧐

Action: build

Failed stage: Run actions/checkout@v3 [❌]

Failure summary: The action failed due to an issue with Git submodules: The error fatal: No url found for submodule path 'scripts/clones/***nfts' in .gitmodules indicates that there is a missing URL for a submodule in the .gitmodules file. This caused the Git command to fail with exit code 128, preventing further progress in the action.

Relevant error logs: 1: ##[group]Operating System 2: Ubuntu ... 426: Switched to a new branch 'alicia/minted-on-rally' 427: branch 'alicia/minted-on-rally' set up to track 'origin/alicia/minted-on-rally'. 428: ##[endgroup] 429: [command]/usr/bin/git log -1 --format='%H' 430: '5fd7f68162f53e24a1a4237f528c4e2f6358128b' 431: ##[group]Removing auth 432: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 433: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 434: ##[error]fatal: No url found for submodule path 'scripts/clones/***nfts' in .gitmodules 435: ##[error]The process '/usr/bin/git' failed with exit code 128 ... 437: [command]/usr/bin/git version 438: git version 2.46.1 439: Temporarily overriding HOME='/home/runner/work/_temp/3f9b849c-94a4-46bf-ae23-d9889da02c5d' before making global git config changes 440: Adding repository directory to the temporary git global config as a safe directory 441: [command]/usr/bin/git config --global --add safe.directory /home/runner/work/mobile-minting/mobile-minting 442: [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand 443: [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :" 444: fatal: No url found for submodule path 'scripts/clones/***nfts' in .gitmodules 445: ##[warning]The process '/usr/bin/git' failed with exit code 128

---

✨ CI feedback usage guide:

---

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

• Failed stage
• Failed test name
• Failure summary
• Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

• enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
• excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
• enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
• persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
• final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.