-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VV Mint Ingestor #65
base: main
Are you sure you want to change the base?
VV Mint Ingestor #65
Conversation
9c5a138
to
6c05827
Compare
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨Explore these optional code suggestions:
|
@@ -9,7 +9,7 @@ export const mintIngestorResources = (): MintIngestorResources => { | |||
} | |||
const settings = { | |||
apiKey: ALCHEMY_API_KEY, | |||
network: Network.BASE_MAINNET, // Replace with the correct network | |||
network: Network.ETH_MAINNET, // Replace with the correct network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is not safe
I prepared this update to handle this scenario:
#48
I'm rebasing it against main now to see if it will merge cleanly & then you should be able to use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This change was global to all ingestors & broke all the other Base ingestors 🤣 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update it after #48 is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a closer look and update the codebase, since opening this PR they implemented a couple of new features.
It looks like the contract's renderer has a JS script that decodes the nft's assets.
User description
Mint Ingestor: VV Mint
Ingestor for VV Mint based on the Mint open-source protocol.
Supports ingestion by contract for other deployments e.g. networked.art and more.
Functionality Supported
Before you submit
src/ingestors
myMintingPlatformGetContractDetails
resources
objectPR Type
Enhancement, Tests
Description
VvIngestor
to handle minting operations for VV contracts, supporting both URL and contract address ingestion.VvIngestor
class, ensuring correct functionality for URL and contract support, as well as mint template creation.Changes walkthrough 📝
index.ts
Add VvIngestor to available mint ingestors
src/ingestors/index.ts
VvIngestor
to the list of available mint ingestors.ALL_MINT_INGESTORS
map to includevv
.abi.ts
Define ABI for VV mint contract
src/ingestors/vv/abi.ts
index.ts
Implement VvIngestor class for minting operations
src/ingestors/vv/index.ts
VvIngestor
class with URL and contract support.instructions.
onchain-metadata.ts
Add on-chain metadata functions for VV contract
src/ingestors/vv/onchain-metadata.ts
collection metadata.
resources.ts
Update network setting to ETH_MAINNET
src/lib/resources.ts
vv.test.ts
Add tests for VvIngestor functionality
test/ingestors/vv.test.ts
VvIngestor
functionality.creation.