Skip to content

Commit

Permalink
PR suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
florelis committed Mar 14, 2024
1 parent 97e9415 commit ce47cf5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
4 changes: 1 addition & 3 deletions src/AppInstallerCLICore/Commands/SettingsCommand.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ namespace AppInstaller::CLI
Utility::LocIndString validOptions = Join(", "_liv, adminSettingList);

if (StringAdminSetting::Unknown == StringToStringAdminSetting(execArgs.GetArg(Execution::Args::Type::SettingName))

{
throw CommandException(Resource::String::InvalidArgumentValueError(ArgumentCommon::ForType(Execution::Args::Type::SettingName).Name, validOptions));
}
Expand Down Expand Up @@ -198,8 +197,7 @@ namespace AppInstaller::CLI

Utility::LocIndString validOptions = Join(", "_liv, adminSettingList);

if (execArgs.Contains(Execution::Args::Type::SettingName)
&& StringAdminSetting::Unknown == StringToStringAdminSetting(execArgs.GetArg(Execution::Args::Type::SettingName))
if (StringAdminSetting::Unknown == StringToStringAdminSetting(execArgs.GetArg(Execution::Args::Type::SettingName))
&& BoolAdminSetting::Unknown == StringToBoolAdminSetting(execArgs.GetArg(Execution::Args::Type::SettingName)))
{
throw CommandException(Resource::String::InvalidArgumentValueError(ArgumentCommon::ForType(Execution::Args::Type::SettingName).Name, validOptions));
Expand Down
1 change: 0 additions & 1 deletion src/AppInstallerCLICore/Workflows/SettingsFlow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ namespace AppInstaller::CLI::Workflow
context.Reporter.Info() << Resource::String::ResetAdminSettingSucceeded(LocIndString{ adminSettingName }) << std::endl;
}
else

{
context.Reporter.Error() << Resource::String::ResetAdminSettingFailed(LocIndString{ adminSettingName }) << std::endl;
}
Expand Down

0 comments on commit ce47cf5

Please sign in to comment.