Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better multi-monitor support #41

Closed
wants to merge 9 commits into from
Closed

Conversation

juster-0
Copy link

@juster-0 juster-0 commented Jul 3, 2022

This changes add ability to set specific monitor for the bar. I've only added xrandr lib, that probably already installed in almost all systems with X11.
Now you can set specific monitor to any bar in a config with option monitor. If monitor option is defined then options x, y and length will be relative to the specific monitor, otherwise will be relative to the combined screen surface.
Option monitor accepts output names from xrandr command.

README.md Outdated Show resolved Hide resolved
@MuhammedZakir
Copy link

IMO, instead of auto, some other name would be better to reflect "combined screen surface" meaning. It's alright even if it's a combined keyword.

@juster-0
Copy link
Author

juster-0 commented Jul 4, 2022

That's a good point, I'll change it to combined, If the pull request will be approved I want to add ability to show the bar relative to cursor/active window, I think auto will be better for these cases.

Co-authored-by: Muhammed Zakir <8190126+MuhammedZakir@users.noreply.github.com>
@florentc
Copy link
Owner

florentc commented Jul 4, 2022

Hello, a huge thank you to you for this long-awaited feature!! This is a great improvement.

I can't test it out until next week so I will postpone review and merge until then.

@juster-0
Copy link
Author

juster-0 commented Jul 5, 2022

Ok. I'm waiting for your review.

@juster-0
Copy link
Author

Hello. Sorry, any updates?

@juster-0
Copy link
Author

Hello. I currently actively work on my fork of the repo, so I want to free my master branch. I’ll create the same pull request with the same commits, but another branch, If you want you can merge it. Sorry for that and thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants