Don't loop over apt (#34)

* don't loop over apt use a list of names instead

* use consistent tab depth

* fix another apt loop

* parse var as jinja2

handlers/main.yml

@@ -26,7 +26,7 @@
       masked: false
       state: reloaded
   when: ansible_virtualization_type != "docker"
-  ignore_errors: ubuntu1604cis_ignore_remount_errors
+  ignore_errors: "{{ ubuntu1604cis_ignore_remount_errors }}"
 
 - name: systemd restart var-tmp.mount
   become: true
@@ -36,7 +36,7 @@
       enabled: true
       masked: false
       state: reloaded
-  ignore_errors: ubuntu1604cis_ignore_remount_errors
+  ignore_errors: "{{ ubuntu1604cis_ignore_remount_errors }}"
 
 - name: generate new grub config
   become: true

molecule/default/playbook.yml

@@ -7,10 +7,9 @@
   pre_tasks:
     - name: install packages for testing under docker
       apt:
-        name: "{{ item }}"
+        name:
+          - openssh-server
         state: present
-      with_items:
-        - openssh-server
     - name: pretask2
       file:
         name: /boot/grub

tasks/post.yml

@@ -11,11 +11,10 @@
 
 - name: "POST | Perform apt package cleanup"
   apt:
-    name: "{{ item }}"
+    name: "{{ apt_rc_packages.stdout_lines }}"
     state: absent
     purge: true
   changed_when: false
   ignore_errors: true
-  with_items: "{{ apt_rc_packages.stdout_lines }}"
   tags:
     - skip_ansible_lint

tasks/section2.yml

@@ -325,11 +325,10 @@
 
 - name: "SCORED | 2.2.2 | PATCH | Ensure X Window System is not installed"
   apt:
-      name: "{{ item }}"
+      name:
+          - "@X Window System"
+          - "x11*"
       state: absent
-  with_items:
-      - "@X Window System"
-      - "x11*"
   when:
       - not ubuntu1604cis_xwindows_required
       - ubuntu1604cis_rule_2_2_2