Add --unique command-line argument
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flother
force-pushed
the
issue-13-add-unique-cli-argument
branch
from
d408501 to
c04de4c
Compare
A few too many clones in here to be good Rust code, but I'll have a stab at removing them later on.
Don't split the Spritesheet struct and implementation blocks.
The previous test only checked that the spreet CLI could run successfully. Now it actually checks that the output is correct: that the `--ratio` changes the size of the sprites, and that the `--unique` flag removes duplicate sprites from the spritesheet and correctly references them by multiple names in the index. The test run output is now put into a temp directory rather than the root of the repo.
Discovered while browsing the docs for the derive_builder crate. https://docs.rs/derive_builder/latest/derive_builder/
flother
force-pushed
the
issue-13-add-unique-cli-argument
branch
from
c04de4c to
abda6d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match spritezero-cli behaviour by supporting a
--uniquecommand-line argument. When given it only includes unique images in the spritesheet but maps them to multiple names in the index file.Fixes #13.