Multi lane bug fix #153
Merged
Multi lane bug fix #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… things to gen_custom_start_pos
eugenevinitsky
requested review from
AboudyKreidieh,
cathywu and
kanaadp
as code owners
|
This should fix #116 |
Closed
| segment_length = length/float(num_edges) | ||
|
|
||
| edges = [] | ||
| for i in range(num_edges): |
There was a problem hiding this comment.
sort of at a high level, why do we want to cut the highway into sections?
There was a problem hiding this comment.
This lets me write tests for the methods that get leaders for subsequent edges; doing this to highways seemed like the cleanest way to test the non-junction version of this
| startlanes : list of int | ||
| list of start lanes | ||
| """ | ||
| return kwargs["start_positions"], kwargs["start_lanes"] |
There was a problem hiding this comment.
do we want this for all scenarios? if so, would be a good idea to create an issue about this
There was a problem hiding this comment.
It seems like a one-off at the moment? I don't see a compelling case for carefully specifying the initial position of vehicles but happy to be convinced otherwise
crystalzyan
pushed a commit
to crystalzyan/flow
that referenced
this pull request
Dec 1, 2018
full unit test coverage for the current codebase, total of 62 tests that take around 12 sec to run. bug fixes and methods to handle edge cases The "safe_velocity" failsafe was also re-written, and now manages to always prevent crashes. visualizer_flow no longer requires you to specify the type of scenario Refactored components: visualizer_CISTAR renamed to visualizer_flow, and all other visualizers were deleted some parts of the accelerations controllers were renamed to maintain some consistency between all controllers. stuff that haven't been tested: get_headway_dict run_long in visualizer_flow (this is still broken) resets after collisions (this used to be broken, but I added a patch. I can't figure out how to recreate the problem though, since it doesn't happen all the time) anything rl (tests take at least 3 sec because of rllab, so moving them all into integration tests) generator base class (could not think of good unit tests)
crystalzyan
pushed a commit
to crystalzyan/flow
that referenced
this pull request
Dec 1, 2018
Multi lane bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to _multi_lane_headways_util
Fixed _multi_lane_headways_util to pass the tests
Modified gen_custom_start_pos to allow for passing of explicit vehicle positions
Fix #147