modified the rllab setup #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AboudyKreidieh
requested review from
cathywu,
eugenevinitsky and
kanaadp
as code owners
| :: | ||
|
|
||
| source activate flow | ||
| source activate flow-rllab |
There was a problem hiding this comment.
This is not the case if you're not using rllab; you won't have this env.
There was a problem hiding this comment.
u create the environment during the rllab setup instructions
There was a problem hiding this comment.
this is in the Setting up section for rllab btw, which is totally optional and assumes u've installed rllab
There was a problem hiding this comment.
Mmm, I was confused by the git diff. Okay!
kjang96
pushed a commit
to kjang96/flow-1
that referenced
this pull request
Sep 1, 2018
standardizing SUMO file and Ray result names Flow experiments can have their names specified in two places: `exp_tag` within `flow_params`, and the key in the dict passed to `ray.tune.run_experiments`. This PR ensures that the names are the same, by making sure the latter key is `flow_params["exp_tag"]` and not any other name. This makes sure that, for a given experiment, the net/cfg files generated by SUMO and the Ray result directories have the same name.
crystalzyan
pushed a commit
to crystalzyan/flow
that referenced
this pull request
Dec 1, 2018
backoff adjustment
crystalzyan
pushed a commit
to crystalzyan/flow
that referenced
this pull request
Dec 1, 2018
eugenevinitsky
pushed a commit
that referenced
this pull request
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they should work now for everyone that had isssue