cleaned up docstring in envs #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AboudyKreidieh
requested review from
cathywu,
eugenevinitsky and
kanaadp
as code owners
nskh
approved these changes
Sep 1, 2018
flow/envs/bay_bridge/base.py
Outdated
| """ The below methods need to be updated by child classes. """ | ||
|
|
||
| def _apply_rl_actions(self, rl_actions): | ||
| """Update by child classes.""" |
There was a problem hiding this comment.
Should this read "update using child classes" or "implemented by child classes"?
flow/envs/green_wave_env.py
Outdated
| """ | ||
| Partial observed state space. Velocities, distance to intersections, | ||
| edge number (for nearby vehicles) traffic light state | ||
| Partial observed state space. |
There was a problem hiding this comment.
Super nitpicky, but should this be "Partially observed"?
There was a problem hiding this comment.
Not too nitpicky, this is a good catch.
kjang96
pushed a commit
to kjang96/flow-1
that referenced
this pull request
Sep 1, 2018
eugenevinitsky
approved these changes
Sep 3, 2018
crystalzyan
pushed a commit
to crystalzyan/flow
that referenced
this pull request
Dec 1, 2018
* cleaned up docstring in envs * added Nish fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.