Skip to content

Conversation

Yasharzf
Copy link
Collaborator

@Yasharzf Yasharzf commented May 6, 2020

Pull request information

  • Status: ready to merge
  • Kind of changes: new feature
  • Related PR or issue: None

Description

Added get_num_not_departed() function to kernel/vehicle. This function will allow us get the difference between number of loaded vehicles and number of departed vehicles.

? (general description)

@Yasharzf Yasharzf changed the title added function to kernel/vehicle to get number of not departed vehiles get not departed vehicles May 6, 2020
Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests pass

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5854

  • 9 of 13 (69.23%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 89.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/core/kernel/vehicle/traci.py 8 12 66.67%
Files with Coverage Reduction New Missed Lines %
flow/core/kernel/vehicle/traci.py 1 87.74%
Totals Coverage Status
Change from base Build 5837: -0.003%
Covered Lines: 9440
Relevant Lines: 10544

💛 - Coveralls

@AboudyKreidieh AboudyKreidieh merged commit 50be2d0 into master May 8, 2020
@AboudyKreidieh AboudyKreidieh deleted the yashar-not-departed branch May 8, 2020 06:51
brentgryffindor pushed a commit that referenced this pull request May 18, 2020
* added function to kernel/vehicle to get number of not departed vehiles

* fixed over indentation of the docstring

* indentation edit

* pep8

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
liljonnystyle pushed a commit that referenced this pull request May 25, 2020
* added function to kernel/vehicle to get number of not departed vehiles

* fixed over indentation of the docstring

* indentation edit

* pep8

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
liljonnystyle pushed a commit that referenced this pull request May 26, 2020
* added function to kernel/vehicle to get number of not departed vehiles

* fixed over indentation of the docstring

* indentation edit

* pep8

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
liljonnystyle pushed a commit that referenced this pull request May 26, 2020
* added function to kernel/vehicle to get number of not departed vehiles

* fixed over indentation of the docstring

* indentation edit

* pep8

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants