Metadata Configuration #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentgryffindor
requested review from
AboudyKreidieh,
cathywu,
eugenevinitsky and
kanaadp
as code owners
flow/core/util.py
Outdated
|
|
||
|
|
||
| def emission_to_csv_large(emission_path, output_path=None): | ||
| """Do exact same thing as emission_to_csv but handles the memory insufficient issue with large emission file.""" |
There was a problem hiding this comment.
Two comments on this:
- Can you specify in the docstring what has changed from the default
emission_to_csvmethod? - This looks like a lot of code duplication. Can we merge it into
emission_to_csvand just add an input parameter to the method to handle this situation?
There was a problem hiding this comment.
This is exactly the same with emission_to_csv except it handles the XML file in a different way that won't cause memory overflow. Maybe I should just replace emssion_to_csv with this new method.
| extra_info, source_id, run_id = self.pipeline_params | ||
| veh_ids = self.k.vehicle.get_ids() | ||
| get_extra_info(self.k.vehicle, extra_info, veh_ids, source_id, run_id) | ||
| except AttributeError as e: |
There was a problem hiding this comment.
Can we be specific (with a comment) what issue you expect to catch here? This can potentially catch a lot of errors later on, and we want to be sure not to have can unexpected behaviors as a result of that.
There was a problem hiding this comment.
Comment added, this is essential for cases where the attribute pipeline_params is not added to this instance.
AboudyKreidieh
requested changes
Jun 10, 2020
…/flow into datapipeline_dev_v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request information
Description
Implemented setting configuration using command line input. Fix some bug in I210 replay. Added a README in flow/datapipeline