Skip to content

perhaps it means to ignore instead of add? #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2020
Merged

perhaps it means to ignore instead of add? #966

merged 1 commit into from
Jun 14, 2020

Conversation

pengyuan-zhou
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6382

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.219%
Totals Coverage Status
Change from base Build 6341: 0.0%
Covered Lines: 9426
Relevant Lines: 10565
💛 - Coveralls

AboudyKreidieh
AboudyKreidieh approved these changes Jun 14, 2020
View reviewed changes
Copy link
Member

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AboudyKreidieh AboudyKreidieh merged commit 5b38dc4 into flow-project:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AboudyKreidieh AboudyKreidieh AboudyKreidieh approved these changes

@cathywu cathywu Awaiting requested review from cathywu

@eugenevinitsky eugenevinitsky Awaiting requested review from eugenevinitsky eugenevinitsky is a code owner

@kanaadp kanaadp Awaiting requested review from kanaadp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pengyuan-zhou @coveralls @AboudyKreidieh