Skip to content

I210 updated #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2020
Merged

I210 updated #970

merged 3 commits into from
Jun 16, 2020

Conversation

AboudyKreidieh
Copy link
Member

@AboudyKreidieh AboudyKreidieh commented Jun 15, 2020 •
edited
Loading

Pull request information

  • Status: ready to merge
  • Kind of changes: update to existing features
  • Related PR or issue: None

Description

This PR updates the simulation parameters for the I-210 subnetwork, and includes the specify_edge_starts and specify_internal_edge_starts methods to the I-210 network class. The latter methods are used to generate the time-space diagrams

@coveralls
Copy link

coveralls commented Jun 15, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 6438

  • 28 of 30 (93.33%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 88.914%
Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/networks/i210_subnetwork.py 21 23 91.3%
Files with Coverage Reduction New Missed Lines %
examples/exp_configs/non_rl/i210_subnetwork.py 2 85.0%
flow/controllers/routing_controllers.py 5 82.76%
Totals Coverage Status
Change from base Build 6427: -0.06%
Covered Lines: 9440
Relevant Lines: 10617
💛 - Coveralls

eugenevinitsky
eugenevinitsky approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AboudyKreidieh AboudyKreidieh merged commit 9e16b19 into master Jun 16, 2020
@AboudyKreidieh AboudyKreidieh deleted the i210-updated branch June 16, 2020 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eugenevinitsky eugenevinitsky eugenevinitsky approved these changes

@cathywu cathywu Awaiting requested review from cathywu

@kanaadp kanaadp Awaiting requested review from kanaadp

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AboudyKreidieh @coveralls @eugenevinitsky