Skip to content

Conversation

liljonnystyle
Copy link
Collaborator

Pull request information

  • Status: ready to merge
  • Kind of changes: new feature

Description

Offset time-space diagram axes so that (0,0) is the start of the domain of interest (i.e. after warmup period and not including upstream ghost edge).

Highway-Single:
flow_62d108acac4d4418b62425806463a92a

I210 Subnetwork:
flow_eb49bb434d37433bbb8cf6a37463407f

liljonnystyle and others added 30 commits June 19, 2020 13:11
* implement HighwayNetwork for Time-Space Diagrams

* fix flake8

* PR fixes

* update docstrings

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
* fixed h-baselines bug

* potential bug fix
* Replicated changes in 867. Changes only made to traci

* Aimsun changes minus reset
* merge custom output and failsafes to master

* add write_to_csv() function to master

* include pipeline README.md

* add data pipeline __init__

* add experiment.py changes

* Update simulate.py

* Update simulate.py

* Update simulate.py

* Update experiment.py

* Update experiment.py

* fix flake8 issues

* fix flake8 issues

* fixed h-baselines bug

* Update experiment.py

* potential bug fix

* merge custom output and failsafes to master

* add write_to_csv() function to master

* include pipeline README.md

* add data pipeline __init__

* add experiment.py changes

* Update simulate.py

* Update simulate.py

* Update simulate.py

* Update experiment.py

* Update experiment.py

* fix flake8 issues

* fix flake8 issues

* Update experiment.py

* Replicated changes in 867. Done bug (#980)

* Replicated changes in 867. Changes only made to traci

* Aimsun changes minus reset

* address aboudy comments

* revert change

* change warning print to ValueError message

* update to new update_accel methods

* address brent comments

* fix import typo

* address comments

* add display_warnings boolean

* add get_next_speed() function to base vehicle class

* revert addition of get_next_speed

* merge custom output and failsafes to master

* add write_to_csv() function to master

* include pipeline README.md

* add data pipeline __init__

* add experiment.py changes

* Update simulate.py

* Update simulate.py

* Update simulate.py

* Update experiment.py

* Update experiment.py

* fix flake8 issues

* fix flake8 issues

* Update experiment.py

* add experiment.py changes

* Update simulate.py

* Update simulate.py

* Update simulate.py

* Update experiment.py

* Update experiment.py

* fix flake8 issues

* address aboudy comments

* revert change

* change warning print to ValueError message

* update to new update_accel methods

* address brent comments

* fix import typo

* address comments

* add display_warnings boolean

* add get_next_speed() function to base vehicle class

* revert addition of get_next_speed

* remove duped line from rebase

* Update base_controller.py

* fix some bugs

* revert change to get_feasible_action call signature

* change print syntax to be python3.5 compliant

* add tests for new failsafe features

* fix failsafe unit tests

* fix failsafe unit tests

* fix unittest syntax

* fix typo

* smooth default to True

* rearrange raise exception for test coverage

* some minor fixes

* cleanup

* moved simulation logging to the simulation kernel (#991)

* moved simulation logging to the simulation kernel

* pydocstyle

* PR fixes

* bug fix

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
Co-authored-by: Kathy Jang <kathyjang@gmail.com>
Co-authored-by: Nathan Lichtlé <nathanlct@icloud.com>
* fixed h-baselines bug

* potential bug fix

* add 210 edgestarts for backwards compatibility

* add 210 edgestarts for backwards compatibility

* add 210 edgestarts for backwards compatibility

* add 210 edgestarts for backwards compatibility

* fastforward PR 989

* fix typo

Co-authored-by: AboudyKreidieh <akreidieh@gmail.com>
* updated requirements.txt and environment.yml

* Visualizer tests fixes

* remove .func

Co-authored-by: akashvelu <akashvelu@berkeley.edu>
Base automatically changed from ak/i210-master-merge to i210_dev July 11, 2020 02:44
@coveralls
Copy link

coveralls commented Jul 11, 2020

Pull Request Test Coverage Report for Build 7056

  • 33 of 71 (46.48%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 83.716%

Changes Missing Coverage Covered Lines Changed/Added Lines %
flow/visualize/time_space_diagram.py 25 63 39.68%
Totals Coverage Status
Change from base Build 7051: 0.09%
Covered Lines: 9989
Relevant Lines: 11932

💛 - Coveralls

@liljonnystyle liljonnystyle merged commit 0e8be95 into i210_dev Jul 12, 2020
@liljonnystyle liljonnystyle deleted the jl-tsd-offsets branch July 12, 2020 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants