Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threading support #67

Closed
wants to merge 2 commits into from
Closed

Conversation

charliewolf
Copy link

This is an implementation of what @lewellyn suggested in #47 to allow users to use threading via IRC.

@charliewolf charliewolf force-pushed the threading branch 2 times, most recently from 3bd89c3 to 319d492 Compare May 21, 2015 16:38
@danpopp
Copy link

danpopp commented Aug 12, 2015

👍

@thmzlt
Copy link

thmzlt commented Aug 14, 2015

I spent the day using the IRC gateway with this code instead of the web app and it worked well. Two things I noticed:

  • I can't see the ID of a thread initiated by me until I get a reply. It would be nice if the gateway returned the ID right after I sent the first message.
  • The <123456> prefix is a bit cumbersome to type. To alleviate that, I would use a single delimiter (e.g. .) and convert the ID to a larger base. For example, instead of <303132> hello!, one could send .6hwc hello! (with radix 36).

@charliewolf
Copy link
Author

@thmzlt You should be able to see the ID without waiting for a reply. Try a different IRC client? Works on ChatZilla.

Any idea on the best way to implement the radix?

@thmzlt
Copy link

thmzlt commented Aug 14, 2015

You should be able to see the ID without waiting for a reply.

Good point. I was using irssi.

Any idea on the best way to implement the radix?

You can convert an integer to/from a different base using #to_i and #to_s:

2015-08-14-223739_276x66_scrot

@junosuarez
Copy link

This feature would be superduper amazing :) 🐈 🌵 🍰

@tzz
Copy link

tzz commented Nov 13, 2015

Suggestion: in addition to <ID> accept ~ MESSAGE for "last thread", ~tzz MESSAGE for "last thread with user tzz", ~~ MESSAGE for "last thread in which I participated", and !2 MESSAGE for "the second previous thread."

This is literally the only thing forcing me and others to use the GUI Flowdock client.

@junosuarez
Copy link

Is there any interest from flowdock in merging this? Any outstanding concerns? I see that this repo continues to receive new commits. This feature would be very useful to me and I'd like to help if I can.

@junosuarez
Copy link

bump

@milanaleksic
Copy link

Can we please merge this? Although I am not the author of this PR, I am for quite some time already using it on my machine without issues, so I don't know why we don't have it upstream. Without this oulu is not that usable

@junosuarez
Copy link

To update my earlier comments on this thread, my team no longer needs this PR since we are switching to Slack, which has excellent IRC support.

@coldpour
Copy link

I'm sorry guys, but the flowdock team is no longer supporting oulu. You are welcome to fork and run your own server. We'd even be willing to point people to your fork if you'd like. IRC has just been deprioritized. I'm sorry for not following up sooner.

@coldpour coldpour closed this Apr 11, 2016
@trezy
Copy link

trezy commented May 10, 2016

@coldpour Would the Flowdock team be willing, then, to transfer ownership of this repository to it's own organization so that the community could then continue managing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants