Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nerdctl #38

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Support for nerdctl #38

wants to merge 7 commits into from

Conversation

kdambekalns
Copy link
Member

This makes beach support nerdctl for use with a containerd setup, like Rancher Desktop.

@kdambekalns kdambekalns self-assigned this Feb 4, 2022
@kdambekalns
Copy link
Member Author

In the end this should be able to use both, docker and nerdctl, depending on the user setup.

And it is not finished yet:

  • relies on docker.sock for the nginx proxy
  • user/group for the database container need to be set
  • some unused flags are still used (e.g. -force during beach down)
  • …

@kdambekalns
Copy link
Member Author

As of now:

$ beach start
INFO Starting reverse proxy and database server ...
INFO[0000] Creating network local_beach
INFO[0000] Creating network LocalBeach_default
WARN[0000] Ignoring: volume: Bind: [CreateHostPath]
WARN[0000] Ignoring: volume: Bind: [CreateHostPath]
WARN[0000] Ignoring: service database: [HealthCheck]
WARN[0000] Ignoring: volume: Bind: [CreateHostPath]
INFO[0000] Ensuring image flownative/localbeach-nginx-proxy:0.3.0
INFO[0000] Ensuring image mariadb:10.5
INFO[0000] Creating container local_beach_database
INFO[0000] Creating container local_beach_nginx
FATA[0000] failed to create shim: OCI runtime create failed: container_linux.go:380: starting container process caused: process_linux.go:545: container init caused: rootfs_linux.go:75: mounting "/var/run/docker.sock" to rootfs at "/tmp/docker.sock" caused: stat /var/run/docker.sock: no such file or directory: unknown
FATA[0000] error while creating container local_beach_nginx: exit status 1
FATAL container startup failed

$ beach down
INFO Stopping reverse proxy and database server ...

@kdambekalns
Replace "docker" with "nerdctl" in exec.RunCommand calls
be1f5e4
@kdambekalns
Change docker-compose.yaml to compose.yaml internally
21512db 
For the database and nginx proxy, use compose.yaml - since it's not
specifically docker, that makes sense. And according to the spec,
that is the preferred name.

https://github.com/compose-spec/compose-spec/blob/master/spec.md#compose-file
@kdambekalns
Drop --remove-orphans from nerdctl compose down
23d4fc8 
That flag is not implemented.

https://github.com/containerd/nerdctl#whale-nerdctl-compose-down
@kdambekalns
Drop --filter from nerdctl ps
45bfe7d 
That flag is not implemented.

https://github.com/containerd/nerdctl#whale-blue_square-nerdctl-ps
@kdambekalns
Use "compose down" instead of "compose rm"
e5c8385 
The "compose rm" command is not implemented… "compose down" does the
same thing.
@kdambekalns
Pass project name for database/nginx compose setup
202d36e 
The (autogenerated) project name ".LocalBeach" is invalid, so pass
"LocalBeach" using a CLI parameter.

The "name" top-level element from the compose spec is not supported,
it seems, otherwise it would have been a better solution.
@kdambekalns
WIP
d7ec420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlemke robertlemke Awaiting requested review from robertlemke

Assignees

@kdambekalns kdambekalns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kdambekalns