Handle library (#793)

src/dataflow/environments/built-in.ts

@@ -23,6 +23,7 @@ import type { RFunctionArgument } from '../../r-bridge/lang-4.x/ast/model/nodes/
 import type { RSymbol } from '../../r-bridge/lang-4.x/ast/model/nodes/r-symbol'
 import type { NodeId } from '../../r-bridge/lang-4.x/ast/model/processing/node-id'
 import { EdgeType } from '../graph/edge'
+import { processLibrary } from '../internal/process/functions/call/built-in/built-in-library'
 
 export const BuiltIn = 'built-in'
 
@@ -158,6 +159,7 @@ registerBuiltInFunctions(['[', '[['],                        processAccess,
 registerBuiltInFunctions(['$', '@'],                         processAccess,             { treatIndicesAsString: true },                                              )
 registerBuiltInFunctions(['if'],                             processIfThenElse,         {},                                                                          )
 registerBuiltInFunctions(['get'],                            processGet,                {},                                                                          )
+registerBuiltInFunctions(['library'],                        processLibrary,            {},                                                                          )
 registerBuiltInFunctions(['<-', '='],                        processAssignment,         { canBeReplacement: true },                                                  )
 registerBuiltInFunctions([':=', 'assign'],                   processAssignment,         {},                                                                          )
 registerBuiltInFunctions(['delayedAssign'],                  processAssignment,         { quoteSource: true },                                                       )

src/dataflow/internal/process/functions/call/built-in/built-in-library.ts

@@ -0,0 +1,44 @@
+import { type DataflowProcessorInformation } from '../../../../../processor'
+import type { DataflowInformation } from '../../../../../info'
+import { processKnownFunctionCall } from '../known-call-handling'
+import type { ParentInformation } from '../../../../../../r-bridge/lang-4.x/ast/model/processing/decorate'
+import type { RFunctionArgument } from '../../../../../../r-bridge/lang-4.x/ast/model/nodes/r-function-call'
+import type { RSymbol } from '../../../../../../r-bridge/lang-4.x/ast/model/nodes/r-symbol'
+import type { NodeId } from '../../../../../../r-bridge/lang-4.x/ast/model/processing/node-id'
+import { dataflowLogger } from '../../../../../logger'
+import { unpackArgument } from '../argument/unpack-argument'
+import type { RString } from '../../../../../../r-bridge/lang-4.x/ast/model/nodes/r-string'
+import { RType } from '../../../../../../r-bridge/lang-4.x/ast/model/type'
+import { wrapArgumentsUnnamed } from '../argument/make-argument'
+
+
+export function processLibrary<OtherInfo>(
+	name: RSymbol<OtherInfo & ParentInformation>,
+	args: readonly RFunctionArgument<OtherInfo & ParentInformation>[],
+	rootId: NodeId,
+	data: DataflowProcessorInformation<OtherInfo & ParentInformation>
+): DataflowInformation {
+	if(args.length !== 1) {
+		dataflowLogger.warn(`Currently only one-arg library-likes are allows (for ${name.content}), skipping`)
+		return processKnownFunctionCall({ name, args, rootId, data }).information
+	}
+	const nameToLoad = unpackArgument(args[0])
+	if(nameToLoad === undefined || nameToLoad.type !== RType.Symbol) {
+		dataflowLogger.warn('No library name provided, skipping')
+		return processKnownFunctionCall({ name, args, rootId, data }).information
+	}
+
+	// treat as a function call but convert the first argument to a string
+	const newArg: RString<OtherInfo & ParentInformation> = {
+		type:     RType.String,
+		info:     nameToLoad.info,
+		lexeme:   nameToLoad.lexeme,
+		location: nameToLoad.location,
+		content:  {
+			quotes: 'none',
+			str:    nameToLoad.content
+		}
+	}
+
+	return processKnownFunctionCall({ name, args: wrapArgumentsUnnamed([newArg], data.completeAst.idMap), rootId, data }).information
+}

src/slicing/criterion/collect-all.ts

@@ -10,6 +10,7 @@ import { guard } from '../../util/assert'
 import { getUniqueCombinationsOfSize } from '../../util/arrays'
 import type { RNodeWithParent } from '../../r-bridge/lang-4.x/ast/model/processing/decorate'
 import type { NodeId } from '../../r-bridge/lang-4.x/ast/model/processing/node-id'
+import { EmptyArgument } from '../../r-bridge/lang-4.x/ast/model/nodes/r-function-call'
 
 /**
  * Defines the filter for collecting all possible slicing criteria.
@@ -49,6 +50,9 @@ export function* collectAllSlicingCriteria<OtherInfo>(ast: RNodeWithParent<Other
 	}
 
 	for(const combination of getUniqueCombinationsOfSize(potentialSlicingNodes, filter.minimumSize, filter.maximumSize)) {
-		yield combination.map(n => `$${n}` as SingleSlicingCriterion)
+		const c = combination.filter(n => n !== undefined && n !== EmptyArgument)
+		if(c.length > 0) {
+			yield c.map(n => `$${n}` as SingleSlicingCriterion)
+		}
 	}
 }

src/slicing/static/visiting-queue.ts

@@ -27,19 +27,17 @@ export class VisitingQueue {
 	 */
 	public add(target: NodeId, env: REnvironmentInformation, envFingerprint: string, onlyForSideEffects: boolean): void {
 		const idCounter = this.idThreshold.get(target) ?? 0
-
 		if(idCounter > this.threshold) {
 			slicerLogger.warn(`id: ${target} has been visited ${idCounter} times, skipping`)
 			this.timesHitThreshold++
 			return
-		} else {
-			this.idThreshold.set(target, idCounter + 1)
 		}
 
 		/* we do not include the in call part in the fingerprint as it is 'deterministic' from the source position */
 		const print = fingerprint(target, envFingerprint, onlyForSideEffects)
 
 		if(!this.seen.has(print)) {
+			this.idThreshold.set(target, idCounter + 1)
 			this.seen.set(print, target)
 			this.queue.push({ id: target, baseEnvironment: env, onlyForSideEffects })
 		}

test/functionality/benchmark/slicer.spec.ts

@@ -90,7 +90,7 @@ cat(d)`
 			}, statInfo)
 			assert.deepStrictEqual(stats.dataflow, {
 				numberOfNodes:               23,
-				numberOfEdges:               37,
+				numberOfEdges:               38,
 				numberOfCalls:               9,
 				numberOfFunctionDefinitions: 0
 			}, statInfo)